Add possibility to enable multi-selection in SelectWithoutFormik #5018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktorvanwijk
force-pushed
the
chore/4908-enable-multi-for-variable-selection-component
branch
from
364b6e0 to
abb3c97
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5018 +/- ##
==========================================
+ Coverage 96.62% 96.63% +0.01%
==========================================
Files 761 761
Lines 25961 26004 +43
Branches 3394 3395 +1
==========================================
+ Hits 25084 25129 +45
+ Misses 611 610 -1
+ Partials 266 265 -1 ☔ View full report in Codecov by Sentry. |
sergei-maertens
requested changes
Jan 14, 2025
viktorvanwijk
force-pushed
the
chore/4908-enable-multi-for-variable-selection-component
branch
2 times, most recently
from
2871d4a to
03048a2
Compare
…onent. Part of #4908, where multi-selection of the variables is needed.
viktorvanwijk
force-pushed
the
chore/4908-enable-multi-for-variable-selection-component
branch
from
03048a2 to
6ff9c0e
Compare
The padding top/bottom of the clear indicator was too large, making the select take up too much vertical space.
sergei-maertens
approved these changes
Jan 15, 2025
viktorvanwijk
deleted the
chore/4908-enable-multi-for-variable-selection-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4908, where multi-selection of the variables is needed.
Changes
Add support for multi-selection in SelectWithoutFormik component
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene